[libcxx-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

Thu Mar 10 11:01:44 PST 2022

SimplyDanny added a comment.

In D121078#3373139 <https://reviews.llvm.org/D121078#3373139>, @philnik wrote:

> In D121078#3373081 <https://reviews.llvm.org/D121078#3373081>, @SimplyDanny wrote:
>
>> I'm happy that you found a reasonable compromise. I like it too. ;)
>>
>> Now, I ask you to help me a little bit with the workflow and the test failures. The review comments are all taken care of as far as I see. One reviewer approved the changes, others are still in a "needs changes"  or an undecided state. Are approvals of all reviewers required? I guess, the test failures have nothing to do with my changes, or have they? Can we just ignore them if they are unrelated?
>
> Please wait for libunwind and libc++ approval. I won't approve, because I'm not familiar with the documentation stuff.
> If the test failures are unrelated you can ignore them.

Okay, I'll wait a few more days and probably ping people again if there is no response until then,

In D121078#3373128 <https://reviews.llvm.org/D121078#3373128>, @aaron.ballman wrote:

> Btw, do you have commit rights for the project? If not, what name and email address would you like used for patch attribution?

I don't have commit rights. Please use "Danny Mösch" with the email address "danny.moesch at icloud.com". Thank you!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121078/new/

https://reviews.llvm.org/D121078