[libcxx-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

Thu Mar 10 10:06:45 PST 2022

philnik added a comment.

In D121078#3373081 <https://reviews.llvm.org/D121078#3373081>, @SimplyDanny wrote:

> I'm happy that you found a reasonable compromise. I like it too. ;)
>
> Now, I ask you to help me a little bit with the workflow and the test failures. The review comments are all taken care of as far as I see. One reviewer approved the changes, others are still in a "needs changes"  or an undecided state. Are approvals of all reviewers required? I guess, the test failures have nothing to do with my changes, or have they? Can we just ignore them if they are unrelated?

Please wait for libunwind and libc++ approval. I won't approve, because I'm not familiar with the documentation stuff.
If the test failures are unrelated you can ignore them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121078/new/

https://reviews.llvm.org/D121078