[libcxx-commits] [PATCH] D121244: [libc++] Don't manually override NDEBUG in the dylib build

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D121244#3368211 <https://reviews.llvm.org/D121244#3368211>, @Quuxplusone wrote:

> LGTM if CI is green. But do I understand correctly that this is still two orthogonal patches — one related to `LIBCXX_ENABLE_ASSERTIONS`, and one completely orthogonal to that in the benchmark code? Prefer to land in two separate git commits, just for hygiene.

Nope -- those are related. Basically, when we stop defining `-DNDEBUG`, the `assertion` is not a noop anymore, and it fails (for the quicksort adversarial vector). Removing the manual setting of `NDEBUG` requires removing the assertion (which has been faulty for a while now, but we never noticed).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121244/new/

https://reviews.llvm.org/D121244