[libcxx-commits] [PATCH] D121244: [libc++] Don't manually override NDEBUG in the dylib build

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 8 12:45:31 PST 2022


Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

LGTM if CI is green. But do I understand correctly that this is still two orthogonal patches — one related to `LIBCXX_ENABLE_ASSERTIONS`, and one completely orthogonal to that in the benchmark code? Prefer to land in two separate git commits, just for hygiene.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121244/new/

https://reviews.llvm.org/D121244



More information about the libcxx-commits mailing list