[libcxx-commits] [PATCH] D120796: [libcxx] Fix the ctype `is` (pointer version) function for Windows

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

LGTM % nit: remove the word "proper", mainly for unnecessary-editorializing but also because I think the editorializing is wrong? Seems to me like the `C` locale "properly" //shouldn't// be using Unicode interpretations! :)



================
Comment at: libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/is_1.pass.cpp:111
+            // On Windows, these wchars are classified according to their
+            // proper Unicode interpretation even in the "C" locale.
+            assert(f.is(F::alpha, L'\x00DA'));
----------------
:)


================
Comment at: libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/is_many.pass.cpp:159
+            // On Windows, these wchars are classified according to their
+            // proper Unicode interpretation even in the "C" locale.
+            assert( (m[0] & F::alpha));
----------------



================
Comment at: libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/scan_is.pass.cpp:67
+            // On Windows, these wchars are classified according to their
+            // proper Unicode interpretation even in the "C" locale, where
+            // the scan_is function returns the same as above for the
----------------



================
Comment at: libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/scan_not.pass.cpp:67
+            // On Windows, these wchars are classified according to their
+            // proper Unicode interpretation even in the "C" locale, where
+            // the scan_is function returns the same as above for the
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120796/new/

https://reviews.llvm.org/D120796