[libcxx-commits] [PATCH] D120796: [libcxx] Fix the ctype `is` (pointer version) function for Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo updated this revision to Diff 412970.
mstorsjo added a comment.

I investigated the behaviour of these tests on odd system codepages, and it actually doesn't affect it. On Windows, wchars are correctly classified according to what unicode the wchar represents even when the "C" locale is set (contrary to other OSes) - regardless of the system codepage.

Thus, I changed the comments to something clearer - now this should be safe and good to go as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120796/new/

https://reviews.llvm.org/D120796

Files:
  libcxx/include/__locale
  libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/is_1.pass.cpp
  libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/is_many.pass.cpp
  libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/scan_is.pass.cpp
  libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/scan_not.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120796.412970.patch
Type: text/x-patch
Size: 8214 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220304/5de1a924/attachment-0001.bin>