[libcxx-commits] [PATCH] D120896: [libc++] Remove _LIBCXX_MODULES_BUILD and ext/ headers from header tests

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D120896#3357193 <https://reviews.llvm.org/D120896#3357193>, @philnik wrote:

> I'd want to avoid that, because after removing `<experimental/algorithm>` we could mechanically check for `#include <algorithm>` to make sure no one's going to include it directly again.

I support that mechanical-check idea (`lint_headers.sh.py` :)) but it'd be 100% trivial to just exclude `ext/hash_set` from that particular check. If we go in @ldionne's suggested direction, of decoupling `ext/` from libc++ proper and moving it into a third-party directory where it is no longer considered part of libc++, we should make it stop including detail headers //anyway//.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120896/new/

https://reviews.llvm.org/D120896