[libcxx-commits] [PATCH] D120896: [libc++] Remove _LIBCXX_MODULES_BUILD and ext/ headers from header tests

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D120896#3357149 <https://reviews.llvm.org/D120896#3357149>, @Quuxplusone wrote:

> It occurred to me this morning that there's yet another option for dealing with `<ext/foo>`. We could add them to the modulemap as textual headers, and then (to avoid the `-Wprivate-header` diagnostic on `<__algorithm/is_permutation.h>`) change them back to including all of `<algorithm>` instead of just `<__algorithm/is_permutation.h>`. `<algorithm>` is a public header, so it would be fine to include from a textual header. Then we wouldn't even need to skip their tests in the modules build.
>
> But I don't object to this direction now and maybe someone'll investigate that direction later. I think the stakes here are low.

I'd want to avoid that, because after removing `<experimental/algorithm>` we could mechanically check for `#include <algorithm>` to make sure no one's going to include it directly again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120896/new/

https://reviews.llvm.org/D120896