[libcxx-commits] [PATCH] D116689: [libunwind][libcxxabi] Use object libraries in the build

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/src/CMakeLists.txt:319
+  if (LIBCXXABI_USE_LLVM_UNWINDER)
+    if (NOT LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_STATIC_LIBRARY AND (TARGET unwind_shared OR HAVE_LIBUNWIND))
+      target_link_libraries(cxx_static PUBLIC unwind_shared)
----------------
ldionne wrote:
> ldionne wrote:
> > Do we really mean to use `LIBCXXABI_foo` variables here?
> Ping on this question.
This naming is preexisting; the options for choosing how to link in the unwind library are sorted under libcxxabi (iirc there’s no corresponding option for libcxx), but in practice, the option is acted upon in both libcxxabi and libcxx, depending on what configuration is used for linking them together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116689/new/

https://reviews.llvm.org/D116689