[libcxx-commits] [PATCH] D116689: [libunwind][libcxxabi] Use object libraries in the build

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.
Herald added a project: All.


================
Comment at: libcxx/src/CMakeLists.txt:233
+    elseif (LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY AND (TARGET unwind_shared_objects OR HAVE_LIBUNWIND))
+      target_link_libraries(cxx_shared PUBLIC unwind_shared_objects)
     else()
----------------
phosek wrote:
> ldionne wrote:
> > compnerd wrote:
> > > Why not use `TARGET_OBJECTS:unwind>` instead?
> > I have the same question.
> AFAIK I can only use `TARGET_OBJECTS` against object library so I need to do `$<TARGET_OBJECTS:unwind_shared_objects>` which works but doesn't simplify things much. Did you have something else in mind?
I think this answers my question.


================
Comment at: libcxx/src/CMakeLists.txt:319
+  if (LIBCXXABI_USE_LLVM_UNWINDER)
+    if (NOT LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_STATIC_LIBRARY AND (TARGET unwind_shared OR HAVE_LIBUNWIND))
+      target_link_libraries(cxx_static PUBLIC unwind_shared)
----------------
ldionne wrote:
> Do we really mean to use `LIBCXXABI_foo` variables here?
Ping on this question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116689/new/

https://reviews.llvm.org/D116689