[libcxx-commits] [PATCH] D127360: [libc++] Drop the legacy debug mode symbols by default

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 3 inline comments as done.
ldionne added a comment.

In D127360#3570599 <https://reviews.llvm.org/D127360#3570599>, @emaste wrote:

> In D127360#3569979 <https://reviews.llvm.org/D127360#3569979>, @ldionne wrote:
>
>> @danalbert  @dim  I think this is worth your input. Can you confirm whether you folks have been shipping symbols like `__ZNSt3__111__libcpp_db10__insert_iEPv` (`std::__1::__libcpp_db::__insert_i(void*)`), and whether you are aware of applications using those symbols?
>
> Looking on my laptop I see `_ZNSt3__111__libcpp_db10__insert_iEPv` in /usr/lib/libc++.so.1, but I suspect they've never been used.

Indeed, my thinking here is that nobody's using these symbols, and if they do, they're already at risk of non-benign ODR violations. In practice, we've seen serious failures trying to use the debug mode in the past, for example in `std::string`. Hence, I suspect nobody's been using them, but at worst vendors could chime in here if they try to deploy this change and encounter issues. That's why I'm leaving a escape hatch too -- to give vendors to quickly remediate to any issue they might find while deploying this and give them time to reach out here so we can figure out a path forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127360/new/

https://reviews.llvm.org/D127360