[libcxx-commits] [PATCH] D127360: [libc++] Drop the legacy debug mode symbols by default

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

A few minor nits. I'm happy when our vendors are happy.



================
Comment at: libcxx/CMakeLists.txt:218
+   with the debug mode enabled. This is OFF by default, please contact the libc++
+   developers if you need to turn this on, as this will be removed in the future." OFF)
 
----------------
Do we want to mention in which version it will be removed?


================
Comment at: libcxx/docs/ReleaseNotes.rst:149
+  you are a vendor and need to re-enable them, please use the ``LIBCXX_ENABLE_BACKWARDS_COMPATIBILITY_DEBUG_MODE_SYMBOLS``
+  CMake flag instead, and contact the libc++ developers as this will be removed in
+  the future. Furthermore, please note that ``LIBCXX_ENABLE_DEBUG_MODE_SUPPORT`` is
----------------
not your change: `instead` looks out of place.


================
Comment at: libcxx/docs/ReleaseNotes.rst:150
+  CMake flag instead, and contact the libc++ developers as this will be removed in
+  the future. Furthermore, please note that ``LIBCXX_ENABLE_DEBUG_MODE_SUPPORT`` is
+  not honored anymore.
----------------
Here too a version number?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127360/new/

https://reviews.llvm.org/D127360