[libcxx-commits] [PATCH] D127444: [libc++] Use ABI tags instead of internal linkage to provide per-TU insulation

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 24 10:55:03 PDT 2022


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

Actually, I think we need to investigate the mangling scheme when the provided ABI tag is a number, because the mangling is `B<size-of-tag><tag>`, so for example the ABI tag "abc" on foo produces "_Z3fooB3abcv", where `3` is the length of the tag. Now consider  the tag `1`, which produces `B11v`, which looks as though it's a tag of length 11.
This seems to break some demanglers, maybe it also will break more?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127444/new/

https://reviews.llvm.org/D127444



More information about the libcxx-commits mailing list