[libcxx-commits] [PATCH] D127444: [libc++] Use ABI tags instead of internal linkage to provide per-TU insulation

Fri Jun 24 10:46:46 PDT 2022

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

It's true that this is a strict improvement over the internal_I guess I'm fine with this if we give Google a way to turn it off, so we don't have to pay the cost of the larger manglings.

================
Comment at: libcxx/include/__config:687
+    _LIBCPP_HIDDEN _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION                                                         \
+        __attribute__((__abi_tag__(_LIBCPP_TOSTRING(_LIBCPP_VERSIONED_IDENTIFIER))))

----------------
Can we give users an ability to turn this off?

================
Comment at: libcxx/test/libcxx/strings/basic.string/PR42676.sh.cpp:7
-//
-//===----------------------------------------------------------------------===//
-
----------------
This test may still have value if we change it to exercise the `__abi_tag__` path instead?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127444/new/

https://reviews.llvm.org/D127444