[libcxx-commits] [PATCH] D128455: [libc++] Improve Lit's buildhost=XXXX feature on a few platforms

[Louis Dionne via Phabricator via libcxx-commits]

ldionne updated this revision to Diff 439520.
ldionne added a comment.

Use new buildhost feature in transitive includes test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128455/new/

https://reviews.llvm.org/D128455

Files:
  libcxx/test/libcxx/transitive_includes.sh.cpp
  libcxx/utils/libcxx/test/features.py


Index: libcxx/utils/libcxx/test/features.py
===================================================================
--- libcxx/utils/libcxx/test/features.py
+++ libcxx/utils/libcxx/test/features.py
@@ -260,9 +260,11 @@
 # The build host could differ from the target platform for cross-compilation.
 DEFAULT_FEATURES += [
   Feature(name='buildhost={}'.format(sys.platform.lower().strip())),
-  # sys.platform can be represented by "sub-system" on Windows host, such as 'win32', 'cygwin', 'mingw' & etc.
-  # Here is a consolidated feature for the build host plaform name on Windows.
-  Feature(name='buildhost=windows', when=lambda cfg: platform.system().lower().startswith('windows'))
+  # sys.platform can often be represented by a "sub-system", such as 'win32', 'cygwin', 'mingw', freebsd13 & etc.
+  # We define a consolidated feature on a few platforms.
+  Feature(name='buildhost=windows', when=lambda cfg: platform.system().lower().startswith('windows')),
+  Feature(name='buildhost=freebsd', when=lambda cfg: platform.system().lower().startswith('freebsd')),
+  Feature(name='buildhost=aix', when=lambda cfg: platform.system().lower().startswith('aix'))
 ]
 
 # Detect whether GDB is on the system, has Python scripting and supports
Index: libcxx/test/libcxx/transitive_includes.sh.cpp
===================================================================
--- libcxx/test/libcxx/transitive_includes.sh.cpp
+++ libcxx/test/libcxx/transitive_includes.sh.cpp
@@ -32,7 +32,7 @@
 // UNSUPPORTED: gcc
 
 // This test doesn't work on AIX or Windows, but it should. Needs investigation.
-// XFAIL: buildhost=aix6, buildhost=windows
+// XFAIL: buildhost=aix, buildhost=windows
 
 // Prevent <ext/hash_map> from generating deprecated warnings for this test.
 #if defined(__DEPRECATED)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128455.439520.patch
Type: text/x-patch
Size: 1777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220623/ddd8b3d1/attachment.bin>