[libcxx-commits] [PATCH] D128455: [libc++] Improve Lit's buildhost=XXXX feature on a few platforms

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 23 12:10:10 PDT 2022

ldionne created this revision.
Herald added subscribers: mstorsjo, arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

  rG LLVM Github Monorepo



Index: libcxx/utils/libcxx/test/features.py
--- libcxx/utils/libcxx/test/features.py
+++ libcxx/utils/libcxx/test/features.py
@@ -260,9 +260,11 @@
 # The build host could differ from the target platform for cross-compilation.
-  # sys.platform can be represented by "sub-system" on Windows host, such as 'win32', 'cygwin', 'mingw' & etc.
-  # Here is a consolidated feature for the build host plaform name on Windows.
-  Feature(name='buildhost=windows', when=lambda cfg: platform.system().lower().startswith('windows'))
+  # sys.platform can often be represented by a "sub-system", such as 'win32', 'cygwin', 'mingw', freebsd13 & etc.
+  # We define a consolidated feature on a few platforms.
+  Feature(name='buildhost=windows', when=lambda cfg: platform.system().lower().startswith('windows')),
+  Feature(name='buildhost=freebsd', when=lambda cfg: platform.system().lower().startswith('freebsd')),
+  Feature(name='buildhost=aix', when=lambda cfg: platform.system().lower().startswith('aix'))
 # Detect whether GDB is on the system, has Python scripting and supports

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128455.439490.patch
Type: text/x-patch
Size: 1237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220623/80774574/attachment.bin>

More information about the libcxx-commits mailing list