[libcxx-commits] [PATCH] D128267: [libc++] Enable [[nodiscard]] extensions by default

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

If we want to move forward with this patch, we're missing a bunch of changes. Please grep for `_LIBCPP_ENABLE_NODISCARD` in the codebase.

Once you've re-uploaded, I'll run a build internally to give us an idea of how the impact it might have on users. I suggest we discuss this once we have more data in hand.

BTW, if we find out that it doesn't break much code, and if we all agree that it's useful to catch bugs, then perhaps it doesn't make sense to provide an escape hatch at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128267/new/

https://reviews.llvm.org/D128267