[libcxx-commits] [PATCH] D128267: [libc++] Enable [[nodiscard]] extensions by default

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/docs/UsingLibcxx.rst:358
 For this reason libc++ provides an extension that does just that! The
-extension must be enabled by defining ``_LIBCPP_ENABLE_NODISCARD``. The extended
-applications of ``[[nodiscard]]`` takes two forms:
+extension is enabled by default and can be disabled by defining ``_LIBCPP_ENABLE_NODISCARD``.
+The extended applications of ``[[nodiscard]]`` takes two forms:
----------------
This needs to read "can be disabled by defining ``_LIBCPP_DISABLE_NODISCARD``" (note disable, not enable in the macro identifier)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128267/new/

https://reviews.llvm.org/D128267