[libcxx-commits] [PATCH] D128053: [libc++] Pass -fno-modules to clang-tidy instead of disabling it for the modules build

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 17 10:08:53 PDT 2022

philnik added a comment.

In D128053#3592505 <https://reviews.llvm.org/D128053#3592505>, @Mordante wrote:

> No real objection, but I think having an XFAIL will give us feedback when modules start working with modules.

I'm using modules for my local build and it's quite annoying having to re-run CMake to be able to run clang-tidy. Since clang doesn't even have complete modules support yet I don't think clang-tidy will work properly with them in the near future.

Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:11
-// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option %{compile_flags}
+// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option %{compile_flags} -fno-modules
 // -Wno-unknown-warning-option tells clang-tidy to ignore '-W' command-line arguments that it doesn't know.
Mordante wrote:
> Let's add a TODO so we can grep to remove it at some point. I expect clang-tidy to work at some point with modules and it might even get module specific diagnostics.
I'll add one when committing if there are no other objections.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list