[libcxx-commits] [PATCH] D128053: [libc++] Pass -fno-modules to clang-tidy instead of disabling it for the modules build

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

No real objection, but I think having an XFAIL will give us feedback when modules start working with modules.



================
Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:11
 
-// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option %{compile_flags}
+// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option %{compile_flags} -fno-modules
 // -Wno-unknown-warning-option tells clang-tidy to ignore '-W' command-line arguments that it doesn't know.
----------------
Let's add a TODO so we can grep to remove it at some point. I expect clang-tidy to work at some point with modules and it might even get module specific diagnostics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128053/new/

https://reviews.llvm.org/D128053