[libcxx-commits] [PATCH] D127650: [libc++] Remove macros for IBM compiler

Mon Jun 13 15:04:29 PDT 2022

ldionne added subscribers: SeanP, hubert.reinterpretcast, daltenty.
ldionne marked an inline comment as done.
ldionne added a comment.

In D127650#3578528 <https://reviews.llvm.org/D127650#3578528>, @Mordante wrote:

> Nice cleanup LGTM! I think it would be good to add some of the IBM people as reviewer too.

We discussed this with @SeanP, but adding others as well.

================
Comment at: libcxx/include/__config:516
-
-#define _LIBCPP_HAS_NO_UNICODE_CHARS
-
----------------
Mordante wrote:
> Can `_LIBCPP_HAS_NO_UNICODE_CHARS` be set in CMake by users? If not this seems to be the only place where `_LIBCPP_HAS_NO_UNICODE_CHARS` is defined.
> 
> In that case do you want to make a followup patch to remove this, or do you want me to do it?
> 
Oh, wow, that's freakin' great. I've been meaning to clean this up for a very long time, but I didn't know how to. I'll actually fold the removal into this patch since it's directly tied to `_LIBCPP_COMPILER_IBM`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127650/new/

https://reviews.llvm.org/D127650