[libcxx-commits] [PATCH] D127650: [libc++] Remove macros for IBM compiler

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Nice cleanup LGTM! I think it would be good to add some of the IBM people as reviewer too.



================
Comment at: libcxx/include/__config:516
-
-#define _LIBCPP_HAS_NO_UNICODE_CHARS
-
----------------
Can `_LIBCPP_HAS_NO_UNICODE_CHARS` be set in CMake by users? If not this seems to be the only place where `_LIBCPP_HAS_NO_UNICODE_CHARS` is defined.

In that case do you want to make a followup patch to remove this, or do you want me to do it?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127650/new/

https://reviews.llvm.org/D127650