[libcxx-commits] [PATCH] D127566: [libc++] Use unsigned char in basic_string::__short again
Joe Loser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Jun 11 11:55:49 PDT 2022
jloser added inline comments.
Comment at: libcxx/include/string:697
+ unsigned char __is_long_ : 1;
> As I already commented on D125496 I think we should add `static_asserts` validating the size. That should catch these errors in our CI.
> (same for the one below.)
I agree re binding this behavior with a test to avoid surprises again in the future.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits