[libcxx-commits] [PATCH] D127566: [libc++] Use unsigned char in basic_string::__short again

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo one comment.



================
Comment at: libcxx/include/string:697
+        unsigned char __is_long_ : 1;
     };
 
----------------
As I already commented on D125496 I think we should add `static_asserts` validating the size. That should catch these errors in our CI.

(same for the one below.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127566/new/

https://reviews.llvm.org/D127566