[libcxx-commits] [PATCH] D126738: [libc++][NFC] Inline the definition of ~basic_ios()

[Alan Zhao via Phabricator via libcxx-commits]

ayzhao added a comment.

In D126738#3564657 <https://reviews.llvm.org/D126738#3564657>, @philnik wrote:

> @ayzhao I think using `virtual ~basic_ios() {}` should work. I think I'm missing something in how `[[gnu::visibility("hidden")]]`, `[[clang::exclude_from_explicit_instantiation]]` and `= default` interact. Sorry for the confusion.

Done. Let's see what happens with the CI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126738/new/

https://reviews.llvm.org/D126738