[libcxx-commits] [PATCH] D126738: [libc++][NFC] Inline the definition of ~basic_ios()

[Alan Zhao via Phabricator via libcxx-commits]

ayzhao updated this revision to Diff 434933.
ayzhao added a comment.

Try an empty destructor instead of = default


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126738/new/

https://reviews.llvm.org/D126738

Files:
  libcxx/include/ios


Index: libcxx/include/ios
===================================================================
--- libcxx/include/ios
+++ libcxx/include/ios
@@ -639,7 +639,7 @@
     // 27.5.4.1 Constructor/destructor:
     _LIBCPP_INLINE_VISIBILITY
     explicit basic_ios(basic_streambuf<char_type,traits_type>* __sb);
-    virtual ~basic_ios();
+    _LIBCPP_INLINE_VISIBILITY virtual ~basic_ios() {};
 
     // 27.5.4.2 Members:
     _LIBCPP_INLINE_VISIBILITY
@@ -694,11 +694,6 @@
     init(__sb);
 }
 
-template <class _CharT, class _Traits>
-basic_ios<_CharT, _Traits>::~basic_ios()
-{
-}
-
 template <class _CharT, class _Traits>
 inline _LIBCPP_INLINE_VISIBILITY
 void


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126738.434933.patch
Type: text/x-patch
Size: 658 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220607/0dfe107d/attachment.bin>