[libcxx-commits] [PATCH] D126915: [libc++abi][AIX][NFC] Use _LIBCXXABI_FUNC_VIS for exported routines
Fangrui Song via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Jun 5 11:49:46 PDT 2022
MaskRay accepted this revision.
MaskRay added a comment.
I see that https://discourse.llvm.org/t/rfc-adding-exported-visibility-style-to-the-ir-to-model-xcoff-exported-visibility/61853 says if no visibility bit (I assume `n_type & SYM_V_MASK` == 0) is set, the symbols need an export list.
I don't see how you use an export list for the libc++abi code, perhaps you maintain a down stream patch.
I assume that getting `#define _LIBCXXABI_FUNC_VIS __attribute__((__visibility__("default")))` will have side effects, so `[NFC]` is inappropriate.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits