[libcxx-commits] [PATCH] D126850: [libc++][test] Skip string_view tests for other vendors on older modes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

There are a few places where the `UNSUPPORTED` isn't in the proper spot, I've marked all of them. Please update these before landing this patch.
Other than these nits, LGTM.



================
Comment at: libcxx/test/std/strings/string.view/char.bad.fail.cpp:12
 
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)
+
----------------
Please move up.


================
Comment at: libcxx/test/std/strings/string.view/string.view.access/front.pass.cpp:13
 
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)
+
----------------
Please move up.


================
Comment at: libcxx/test/std/strings/string.view/string.view.find/find_last_not_of_string_view_size.pass.cpp:13
 
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)
+
----------------
Please move up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126850/new/

https://reviews.llvm.org/D126850