[libcxx-commits] [PATCH] D126850: [libc++][test] Skip string_view tests for other vendors on older modes

[Joe Loser via Phabricator via libcxx-commits]

jloser marked an inline comment as done.
jloser added inline comments.


================
Comment at: libcxx/test/std/strings/string.view/string.view.hash/string_view.pass.cpp:18
 
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)
+
----------------
Mordante wrote:
> Can you move this more to the top, (before `// <functional>`) of the file like we do in the other tests?
> 
> Same for other places.
Done! Good spot.


================
Comment at: libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp:31
+    SV  sv4 { s + 1, 4 };
+    SV  sv5 { s    , 5 };
     SV  svNot {"def", 3 };
----------------
Mordante wrote:
> Is this intended? It adds new unused variables.
> 
> (This file contains a similar commented out block at line 71.)
> 
> The same for the next file.
Sorry, this was done in a separate PR (https://github.com/llvm/llvm-project/commit/6423a9f0ec8ba70049ea76e7bcfc9a9d1a54e826) and was wrong to begin with. It is fixed with https://reviews.llvm.org/D126901


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126850/new/

https://reviews.llvm.org/D126850