[libcxx-commits] [PATCH] D126901: [libc++][test] Fix unused variable warning in string_view tests

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 2 12:34:16 PDT 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4be36dc77fc9: [libc++][test] Fix unused variable warning in string_view tests (authored by joe_loser).

Changed prior to commit:
  https://reviews.llvm.org/D126901?vs=433808&id=433843#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126901/new/

https://reviews.llvm.org/D126901

Files:
  libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp
  libcxx/test/std/strings/string.view/string.view.template/starts_with.ptr.pass.cpp


Index: libcxx/test/std/strings/string.view/string.view.template/starts_with.ptr.pass.cpp
===================================================================
--- libcxx/test/std/strings/string.view/string.view.template/starts_with.ptr.pass.cpp
+++ libcxx/test/std/strings/string.view/string.view.template/starts_with.ptr.pass.cpp
@@ -26,9 +26,6 @@
     SV  sv0 {};
     SV  sv1 { s, 1 };
     SV  sv2 { s, 2 };
-    SV  sv3 { s, 3 };
-    SV  sv4 { s, 4 };
-    SV  sv5 { s, 5 };
     SV  svNot {"def", 3 };
 
     LIBCPP_ASSERT_NOEXCEPT(sv0.starts_with(""));
@@ -68,9 +65,6 @@
     constexpr SV  sv0 {};
     constexpr SV  sv1 { s, 1 };
     constexpr SV  sv2 { s, 2 };
-//     constexpr SV  sv3 { s, 3 };
-//     constexpr SV  sv4 { s, 4 };
-//     constexpr SV  sv5 { s, 5 };
     constexpr SV  svNot {"def", 3 };
 
     static_assert ( sv0.starts_with(""), "" );
Index: libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp
===================================================================
--- libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp
+++ libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp
@@ -26,9 +26,6 @@
     SV  sv0 {};
     SV  sv1 { s + 4, 1 };
     SV  sv2 { s + 3, 2 };
-    SV  sv3 { s + 2, 3 };
-    SV  sv4 { s + 1, 4 };
-    SV  sv5 { s    , 5 };
     SV  svNot {"def", 3 };
 
     LIBCPP_ASSERT_NOEXCEPT(sv0.ends_with(""));
@@ -68,9 +65,6 @@
     constexpr SV  sv0 {};
     constexpr SV  sv1 { s + 4, 1 };
     constexpr SV  sv2 { s + 3, 2 };
-//     constexpr SV  sv3 { s + 2, 3 };
-//     constexpr SV  sv4 { s + 1, 4 };
-//     constexpr SV  sv5 { s,     5 };
     constexpr SV  svNot {"def", 3 };
 
     static_assert ( sv0.ends_with(""), "" );


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126901.433843.patch
Type: text/x-patch
Size: 1762 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220602/56a9f2d2/attachment.bin>


More information about the libcxx-commits mailing list