[libcxx-commits] [PATCH] D126901: [libc++][test] Fix unused variable warning in string_view tests
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jun 2 11:25:57 PDT 2022
Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM after addressing the review comments.
================
Comment at: libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp:68
constexpr SV sv2 { s + 3, 2 };
// constexpr SV sv3 { s + 2, 3 };
// constexpr SV sv4 { s + 1, 4 };
----------------
Remove these too please.
================
Comment at: libcxx/test/std/strings/string.view/string.view.template/starts_with.ptr.pass.cpp:70
// constexpr SV sv4 { s, 4 };
// constexpr SV sv5 { s, 5 };
constexpr SV svNot {"def", 3 };
----------------
Remove these too please.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126901/new/
https://reviews.llvm.org/D126901
More information about the libcxx-commits
mailing list