[libcxx-commits] [PATCH] D130649: [libc++][format] Allows width arg-id with value 0.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/test/std/utilities/format/format.functions/format_tests.h:242
+  // Width 0 allowed, but not useful for string arguments.
+  check.template operator()<"hello {:{}}">(SV("hello world"), world, 0);
+
----------------
vitaut wrote:
> As before, I'd recommend getting rid of `template operator()<...>` in favor of something more readable like a normal function call.
Agreed, that's on my todo list. But I want to look at that when there are no patches in review that would result in merge conflicts. (The wouldn't be hard to solve, but I prefer avoiding the hassle.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130649/new/

https://reviews.llvm.org/D130649