[libcxx-commits] [PATCH] D130649: [libc++][format] Allows width arg-id with value 0.

Victor Zverovich via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 27 14:47:11 PDT 2022


vitaut added a comment.

One check less, yay!



================
Comment at: libcxx/test/std/utilities/format/format.functions/format_tests.h:242
+  // Width 0 allowed, but not useful for string arguments.
+  check.template operator()<"hello {:{}}">(SV("hello world"), world, 0);
+
----------------
As before, I'd recommend getting rid of `template operator()<...>` in favor of something more readable like a normal function call.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130649/new/

https://reviews.llvm.org/D130649



More information about the libcxx-commits mailing list