[libcxx-commits] [PATCH] D130715: [libc++][AIX] Use non-unique implementation for typeinfo comparison

Xing Xue via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 28 10:20:49 PDT 2022


xingxue marked an inline comment as done.
xingxue added inline comments.


================
Comment at: libcxx/include/typeinfo:177
 
-  // Windows binaries can't merge typeinfos, so use the NonUnique implementation.
-# ifdef _LIBCPP_OBJECT_FORMAT_COFF
+  // Windows or AIX binaries can't merge typeinfos, so use the NonUnique implementation.
+# if defined(_LIBCPP_OBJECT_FORMAT_COFF) || defined(_LIBCPP_OBJECT_FORMAT_XCOFF)
----------------
philnik wrote:
> 
Changed the comment as suggested.  Thanks, @philnik!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130715/new/

https://reviews.llvm.org/D130715



More information about the libcxx-commits mailing list