[libcxx-commits] [PATCH] D130715: [libc++][AIX] Use non-unique implementation for typeinfo comparison

Xing Xue via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 28 10:18:52 PDT 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaeb1c98f4c10: [libc++][AIX] Use non-unique implementation for typeinfo comparison (authored by xingxue).

Changed prior to commit:
  https://reviews.llvm.org/D130715?vs=448358&id=448373#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130715/new/

https://reviews.llvm.org/D130715

Files:
  libcxx/include/typeinfo


Index: libcxx/include/typeinfo
===================================================================
--- libcxx/include/typeinfo
+++ libcxx/include/typeinfo
@@ -174,8 +174,8 @@
 // we pick a default implementation based on the platform here.
 #ifndef _LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION
 
-  // Windows binaries can't merge typeinfos, so use the NonUnique implementation.
-# ifdef _LIBCPP_OBJECT_FORMAT_COFF
+  // Windows and AIX binaries can't merge typeinfos, so use the NonUnique implementation.
+# if defined(_LIBCPP_OBJECT_FORMAT_COFF) || defined(_LIBCPP_OBJECT_FORMAT_XCOFF)
 #   define _LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION 2
 
   // On arm64 on Apple platforms, use the special NonUniqueARMRTTIBit implementation.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130715.448373.patch
Type: text/x-patch
Size: 732 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220728/b209f39a/attachment.bin>


More information about the libcxx-commits mailing list