[libcxx-commits] [PATCH] D128146: [libc++] Use uninitialized algorithms for vector

Mon Jul 25 05:46:52 PDT 2022

hans added a comment.

In D128146#3673017 <https://reviews.llvm.org/D128146#3673017>, @philnik wrote:

> @joanahalili @hans @alexfh Could you check whether the current patch fixes the binary size problems?

It helps a little. With the original version of this (23cf42e706fb <https://reviews.llvm.org/rG23cf42e706fbc2a939ce1470da16599b42258aea>) we got:

  ld.lld: error: output file too large: 4306465056 bytes

With the new version:

  ld.lld: error: output file too large: 4305167360 bytes

Without any of those (at b4722cc4c96e <https://reviews.llvm.org/rGb4722cc4c96e03cdad3f23b0ba558907e82d95db>) the binary is 4244939036 bytes

which is very close to the 4 GB limit, so we have to address that anyway, I just wanted to flag this so the growth didn't go unnoticed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128146/new/

https://reviews.llvm.org/D128146