[libcxx-commits] [PATCH] D128146: [libc++] Use uninitialized algorithms for vector

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D128146#3674260 <https://reviews.llvm.org/D128146#3674260>, @eaeltsin wrote:

> Thanks a lot, @huixie90!
>
> Then it might be, that the tests I'm seeing failing were calling one ctor before this patch and another ctor with this patch.
>
> Maybe now this ctor resolution flakiness happens where `memcpy` versions were called before? Thinking about how to check this...

The problem is exactly as @huixie90 described. The reason this issue became apparent with this patch is that we call the constructor during constant evaluation. During runtime the calls still get forwarded to `memmove`. The interesting part for you is `uninitialized_algorithms.h:566-578`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128146/new/

https://reviews.llvm.org/D128146