[libcxx-commits] [PATCH] D130321: [libc++][ranges] Implement `ranges::shuffle`.

Hui via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 22 11:09:30 PDT 2022


huixie90 added inline comments.


================
Comment at: libcxx/include/__algorithm/ranges_shuffle.h:70
+    _LIBCPP_HIDE_FROM_ABI
+    constexpr auto operator()() const { return __gen(); }
+  };
----------------
not an issue but just write it down as I had thought about it. 

Not sure how this could possibly go wrong but the original requirement is that you can do `std::invoke(__gen)`. I guess it is ok to call `__gen()` instead of but I'd still prefer to stick to original requirement



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130321/new/

https://reviews.llvm.org/D130321



More information about the libcxx-commits mailing list