[libcxx-commits] [PATCH] D130321: [libc++][ranges] Implement `ranges::shuffle`.

[Hui via Phabricator via libcxx-commits]

huixie90 added a comment.

LGTM



================
Comment at: libcxx/test/support/test_iterators.h:828
+  constexpr friend void iter_swap(Iterator a, Iterator b) {
+    std::swap(a.ptr_, b.ptr_);
     if (a.iter_swaps_) {
----------------
not sure how this is used in the test but usually `iter_swap` would swap the underlying references i.e `std::swap(*a.ptr_, *b.ptr_)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130321/new/

https://reviews.llvm.org/D130321