[libcxx-commits] [PATCH] D129768: [libc++] Remove the option to change _LIBCPP_OVERRIDABLE_FUNC_VIS

[Reid Kleckner via Phabricator via libcxx-commits]

rnk added a comment.

"... once Chromium fixes the bugs this option circumvents"

When this issue is ultimately resolved, I think it will require a libc++ customization point. I don't see a good way to use fvisibility=hidden, hide libc++ symbols, but override operator new & delete with default visibility symbols, without an ifdef here. Certainly, we can come up with a better customization point than this ifdef. I just mean that it's highly unlikely that this patch should land as is. Instead there will be other libc++ changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129768/new/

https://reviews.llvm.org/D129768