[libcxx-commits] [PATCH] D129768: [libc++] Remove the option to change _LIBCPP_OVERRIDABLE_FUNC_VIS

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

> Is there anything in the release notes that it's the intention to remove this?

No, there isn't. Normally we don't release-note refactoring internal code.

> We know it broke Chromium, but we don't know how many other might be broken.

I suspect there aren't a lot of people who do this. You have to link libc++ statically, define `_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS`, use `-fvisibility=hidden` and want a custom `operator new/operator delete` that is in a (different) dylib.

> Instead I would suggest to follow our normal removal route once Chromium is fixed:
>
> - Remove it, but add an opt out
> - Add information in the release notes, requesting people to reach out when they use it
> - Remove the opt out in a later release

Do you have a suggestion of how that opt-out should look like?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129768/new/

https://reviews.llvm.org/D129768