[libcxx-commits] [PATCH] D129716: [libc++][NFC] Use is_void instead of is_same<void, ...>

Fri Jul 15 23:21:17 PDT 2022

nilayvaish added a comment.

In D129716#3655911 <https://reviews.llvm.org/D129716#3655911>, @Mordante wrote:

> Can you explain what the benefit of this change is? And why the different behaviour of `std::same_as` and `std::is_void_v` is not an issue. I'm not even sure we should call this an NFC patch.
>
> In general it would be good to add this kind of information to the commit message/review description.

The patch is replacing `std::is_same` with a more specialized version `std::is_void`.  This patch seems fine to me.  Two questions:

- Why do we have the specialized version  at all?
- Why does `std::same_as` matter here?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129716/new/

https://reviews.llvm.org/D129716