[libcxx-commits] [PATCH] D129716: [libc++][NFC] Use is_void instead of is_same<void, ...>
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jul 15 11:21:31 PDT 2022
Mordante added a comment.
Can you explain what the benefit of this change is? And why the different behaviour of `std::same_as` and `std::is_void_v` is not an issue. I'm not even sure we should call this an NFC patch.
In general it would be good to add this kind of information to the commit message/review description.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129716/new/
https://reviews.llvm.org/D129716
More information about the libcxx-commits
mailing list