[libcxx-commits] [PATCH] D122536: [libc++] Optimize `exception_ptr`, especially for the empty case

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D122536#3634273 <https://reviews.llvm.org/D122536#3634273>, @fwolff wrote:

> Thanks for your help @philnik. I'm still unsure what exactly I should check for in the `exception` header; I went for
>
>   #if defined(_LIBCPP_ABI_VERSION) || defined(LIBCXXRT) || defined(LIBCXX_BUILDING_LIBCXXABI)
>
> because the first two are used in `libcxx/src/exception.cpp` to indicate that the `exception_pointer_cxxabi.ipp` implementation is to be used, and it didn't work without the last one, but it doesn't really look right to me, so please comment.

I'm not actually sure what the right is here. I think @ldionne should take a look, as he is more familiar with these things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122536/new/

https://reviews.llvm.org/D122536