[libcxx-commits] [PATCH] D122536: [libc++] Optimize `exception_ptr`, especially for the empty case

Fabian Wolff via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 6 17:11:43 PDT 2022


fwolff updated this revision to Diff 442726.
fwolff added a comment.

Thanks for your help @philnik. I'm still unsure what exactly I should check for in the `exception` header; I went for

  #if defined(_LIBCPP_ABI_VERSION) || defined(LIBCXXRT) || defined(LIBCXX_BUILDING_LIBCXXABI)

because the first two are used in `libcxx/src/exception.cpp` to indicate that the `exception_pointer_cxxabi.ipp` implementation is to be used, and it didn't work without the last one, but it doesn't really look right to me, so please comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122536/new/

https://reviews.llvm.org/D122536

Files:
  libcxx/include/exception
  libcxx/src/exception.cpp
  libcxx/src/support/runtime/exception_pointer_cxxabi.ipp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122536.442726.patch
Type: text/x-patch
Size: 6353 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220707/7aa20390/attachment.bin>


More information about the libcxx-commits mailing list