[libcxx-commits] [PATCH] D118188: [libcxx] [Windows] Pick a unique bit for __regex_word

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/re/re.traits/lookup_classname.pass.cpp:33
+              std::ctype_base::__regex_word,
+              "__regex_word can't overlap other bits");
+
----------------
Quuxplusone wrote:
> (1) Couldn't this go in `include/__locale` today, just guarded with `#if !defined(_AIX)` and a TODO comment?
> (2) I don't think this can go in `libcxx/test/std/` because `__regex_word` isn't a standard name. It should go in `libcxx/test/libcxx/` (unless you just put it in `include/__locale`).
Yeah, that should work too, and good point about this being a standard test. (I went with placing it in a test instead of in the header, to break less if there’s other platforms where it doesn’t pass, that aren’t covered by CI. But if it isn’t covered by CI, we can’t give any promises I guess.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118188/new/

https://reviews.llvm.org/D118188