[libcxx-commits] [PATCH] D118188: [libcxx] [Windows] Pick a unique bit for __regex_word

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jan 29 09:08:29 PST 2022


Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/re/re.traits/lookup_classname.pass.cpp:33
+              std::ctype_base::__regex_word,
+              "__regex_word can't overlap other bits");
+
----------------
(1) Couldn't this go in `include/__locale` today, just guarded with `#if !defined(_AIX)` and a TODO comment?
(2) I don't think this can go in `libcxx/test/std/` because `__regex_word` isn't a standard name. It should go in `libcxx/test/libcxx/` (unless you just put it in `include/__locale`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118188/new/

https://reviews.llvm.org/D118188



More information about the libcxx-commits mailing list