[libcxx-commits] [PATCH] D118507: [libc++] Merge _LIBCPP_HAS_NO_RANGES into _LIBCPP_HAS_NO_CONCEPTS. NFC

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__config:882
 
-#if _LIBCPP_STD_VER <= 17 || defined(_LIBCPP_HAS_NO_CONCEPTS)
-#define _LIBCPP_HAS_NO_RANGES
----------------
How about keeping this and test it for `_LIBCPP_HAS_NO_INCOMPLETE_RANGES` too? Wouldn't that solve our problem with not testing `_LIBCPP_HAS_NO_INCOMPLETE_RANGES` everywhere. Of course that would mean we keep both `_LIBCPP_HAS_NO_CONCEPTS` and `_LIBCPP_HAS_NO_RANGES`.

Note that adding `_LIBCPP_HAS_NO_INCOMPLETE_RANGES` was a kind of hurried last minute fix for the LLVM 13 release, but in hindsight updating this part of the `__config` sounds like a good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118507/new/

https://reviews.llvm.org/D118507