[libcxx-commits] [PATCH] D118507: [libc++] Merge _LIBCPP_HAS_NO_RANGES into _LIBCPP_HAS_NO_CONCEPTS. NFC

Fri Jan 28 17:33:40 PST 2022

jloser accepted this revision.
jloser added a comment.

LGTM! Thanks for cleaning this up.

I'd be in favor of  a patch that guards the `enable_view` for `directory_iterator` and `recursive_directory_iterator` with `_LIBCPP_HAS_NO_INCOMPLETE_RANGES` instead as you pointed out.

================
Comment at: libcxx/include/__filesystem/directory_iterator.h:136

-#if !defined(_LIBCPP_HAS_NO_RANGES)
+#if !defined(_LIBCPP_HAS_NO_CONCEPTS)

----------------
Quuxplusone wrote:
> @ldionne: Here's an example of something that should probably be guarded under `_LIBCPP_HAS_NO_INCOMPLETE_RANGES` (instead of `_LIBCPP_HAS_NO_CONCEPTS`).
Agreed. I added these IIRC, but copied the `#ifdef` check from somewhere else likely but never chased down the differences between concepts/ranges checks. I'd be fine if you change this to `_LIBCPP_HAS_NO_INCOMPLETE_RANGES`.

================
Comment at: libcxx/include/__filesystem/recursive_directory_iterator.h:167

-#if !defined(_LIBCPP_HAS_NO_RANGES)
+#if !defined(_LIBCPP_HAS_NO_CONCEPTS)

----------------
Let's also guard this with `_LIBCPP_HAS_NO_INCOMPLETE_RANGES` as in the `directory_iterator` case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118507/new/

https://reviews.llvm.org/D118507