[libcxx-commits] [PATCH] D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.assign/unique_ptr_Y.pass.cpp:129
+#ifdef _LIBCPP_VERSION // Bogus test cases assign unique_ptr<Y> to shared_ptr<T> despite that
+                       // Y* and T* are not compatible per [util.smartptr.shared.general]/6.
     {
----------------
Mordante wrote:
> Thanks for filing a bug report! Can you add a link to the bug in the comments?
+1, please add `// https://llvm.org/PR53368` on each of these lines (and then the longer comment is probably superfluous). Whoever fixes PR53368 should `git grep` for mentions of it, which will lead them here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117996/new/

https://reviews.llvm.org/D117996